[Open Office] OOo Status digest issue #6 - June 11th 2007

[Jan Holesovsky]

Hi Hub

On Wednesday 13 June 2007 00:33, Hubert Figuiere wrote:
> On Tue, 2007-06-12 at 18:29 +0200, Jan Holesovsky wrote:
> > It was not really a work on qatesttool, but a work based on
> > qatesttool
> > results ;-)  qatesttool uncovered a 64bit problem here, and I fixed
> > that:
> >
> > http://www.openoffice.org/issues/show_bug.cgi?id=78198
>
> Which lead to the question:
>
> Shouldn't we really change the container instead?
>
> I know it is work, but typically this is the kind of bad type cast that
> should be avoided as much as possible.

Well, generally there's nothing bad with having the possibility to be able to 
count to ULONG_MAX; it is just a bit too much in 64bit case ;-), and that's 
why I thought we could change Container - on 32bit, 32bit ULONG_MAX is 
sufficient as well.

OTOH - ULONG is OK there as long as it is used consistently, and that is fixed 
by the patch, so - I don't think it is worth the effort ;-)

Regards,
Jan