[Open Office] fontconfig patches from FC

Robert Vojta robert at vojta.name
Fri Sep 29 08:03:57 EDT 2006


On Fri, 2006-09-29 at 11:42 +0200, Robert Vojta wrote:

Hallo Matthias,

> when I apply your latest fontconfig-* patches (from FC), ooo-build fails
> to build for Windows somewhere in vcl. AFAIK it was something to do with
> 'std::abs', but I can't remember, haven't access to my home machine logs
> now. I'll send you more details tomorrow ...

  as tml wrote on IRC, it's enough to change ...

  if ((n+1 < nLevel) && (std::abs(nCharPos[n] - nOrigCharPos)))

  ... to ...

  if ((n+1 < nLevel) && ((nCharPos[n] - nOrigCharPos) != 0))

  Hmm, but I think that there is another mistake in this patch too. Look
at following conditions. The 1st and 2nd are same.

+     if (nOrigCharPos < nCharPos[n])   <---!!!!!
+     {
+         if (nCharPos[n+1] > nOrigCharPos && (nCharPos[n+1] < nCharPos[n]))
+            break;
+     }
+     else if (nOrigCharPos < nCharPos[n]) <---!!!!!!
+     {
+         if (nCharPos[n+1] > nCharPos[n] && (nCharPos[n+1] < nOrigCharPos))
+             break;
+     }

  And the next thing from tml is, how can nOrigCharPos differ from
nCharPos[n] when nOrigCharPos is defined as int nOrigCharPos = nCharPos[n]?

-- 
Robert Vojta



More information about the Openoffice mailing list