[Open Office] Is it the right place submitting patches to ooo-build?

[Jody Goldberg]

On Thu, Oct 06, 2005 at 02:29:01PM +0800, Funda Wang wrote:
> Hello,
> 
> Is here the right place submitting patches to ooo-build?

It is a reasonable place to start.

> I would like to suggest a patch against OOo's
> rendering on CJK characters.
I assume you're refering to
    http://www.openoffice.org/nonav/issues/showattachment.cgi/30170/openoffice-1.9.m130-vcl-virtualstyles-20050919-01.patch

> But it seems that the corresponding maintainer of OOo hasn't
> commented on this issue, even if the issue has won more than 300
> votes.

The patch seems viable but there are some stylistic improvements
that could make it cleaner.
     - Remove the white space changes.
     - Rather than commenting 'added by mr firefly' it would be more
       helpful to reference the issuezilla number.
     - Some of the changes are not commented or do not comment at a
       high enough level.
	a) Why is 20pts a reasonable threshold to increase the
	font's gamma ?

	b) Why do this ?
	-    FT_Int nLoadFlags = FT_LOAD_NO_HINTING | FT_LOAD_NO_BITMAP;
	+    FT_Int nLoadFlags = FT_LOAD_DEFAULT | FT_LOAD_TARGET_LIGHT;

	c) Are those the only code pages that are interesting ?

None of these are huge hurdles but it would be nice to see some
discussion either in comments in the patch or in bugzilla with a
reference from the patch.